[tor-bugs] #2332 [Tor Relay]: dnsserv_resolved has needless casts, unused strndup.

[Tor Bug Tracker & Wiki]

#2332: dnsserv_resolved has needless casts, unused strndup.
-----------------------+----------------------------------------------------
 Reporter:  rransom    |       Owner:                    
     Type:  defect     |      Status:  needs_review      
 Priority:  major      |   Milestone:  Tor: 0.2.1.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:  easy       |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by cypherpunks):

 {{{
 eventdns.c then rejects any name of length over 255, so the
 bogus data would be neither transmitted nor altered.
 }}}
 So there memleak, memleak. Any memleak missed? Either it's still there.
 Most obvious, if name of length over 255:
 {{{
   evdns_server_request_respond(req, err);

   conn->dns_server_request = NULL;
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2332#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online