[tor-bugs] #2330 [Tor Client]: SOCKS client cannot handle responses longer than 128 bytes

Mon Jan 10 21:57:24 UTC 2011

#2330: SOCKS client cannot handle responses longer than 128 bytes
------------------------+---------------------------------------------------
 Reporter:  rransom     |       Owner:                    
     Type:  defect      |      Status:  new               
 Priority:  minor       |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:  easy        |      Parent:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Given that the reply format is:

 {{{
         +----+-----+-------+------+----------+----------+
         |VER | REP |  RSV  | ATYP | BND.ADDR | BND.PORT |
         +----+-----+-------+------+----------+----------+
         | 1  |  1  | X'00' |  1   | Variable |    2     |
         +----+-----+-------+------+----------+----------+
 }}}

 and the longest possible length for BND.ADDR is 256 (one length byte, 255
 hostname bytes), I think we're looking at 232 as the longest possible
 length for a socks reply.  Let's round up to doing a pullup(512).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2330#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online