[tor-bugs] #2328 [Tor Client]: addressmap_get_virtual_address insanity

[Tor Bug Tracker & Wiki]

#2328: addressmap_get_virtual_address insanity
------------------------+---------------------------------------------------
 Reporter:  rransom     |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  major       |   Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by cypherpunks):

 Oh. Seems like not all broken configs was spotted, alas.
 if you said "VirtualAddrNetwork 127.0.0.1/32" or something like that. You
 expected only one virtual address, but after:
 {{{
       if (!strmap_get(addressmap, fmt_addr32(next_virtual_addr))) {
         ++next_virtual_addr;
         break;
       }
 }}}
 Next addressmap_get_virtual_address() returns "127.0.0.2", next ".3", and
 so on until ".254" (.255 have a catch by while{}).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2328#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online