[tor-bugs] #2328 [Tor Client]: addressmap_get_virtual_address insanity

[Tor Bug Tracker & Wiki]

#2328: addressmap_get_virtual_address insanity
------------------------+---------------------------------------------------
 Reporter:  rransom     |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  major       |   Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by cypherpunks):

 For counting stuff need to fix:
 {{{
       while ((next_virtual_addr & 0xff) == 0 ||
              (next_virtual_addr & 0xff) == 0xff) {
         ++next_virtual_addr;
       }
 }}}
 Should be --available for every ++next_virtual_addr:
 {{{
       while ((next_virtual_addr & 0xff) == 0 ||
              (next_virtual_addr & 0xff) == 0xff) {
         ++next_virtual_addr;
         if (! --available) {
           log_warn(LD_CONFIG, "Ran out of virtual addresses!");
           return NULL;
         }
       }
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2328#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online