[tor-bugs] #2328 [Tor Client]: addressmap_get_virtual_address insanity

[Tor Bug Tracker & Wiki]

#2328: addressmap_get_virtual_address insanity
------------------------+---------------------------------------------------
 Reporter:  rransom     |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  major       |   Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:2 nickm]:
 > Possible fix for this bug (and a related one) in branch bug2328_021 in
 my public repository.  Needs review.
 Your branch doesn't fix the `tor_strdup(buf)` with `buf` uninitialized
 introduced in
 [https://gitweb.torproject.org/tor.git/commit/22f723e4a3fc32983480c7403af9d7e77a3200ea
 22f723e4a3fc32983480c7403af9d7e77a3200ea] (on branch master, but not
 maint-0.2.2 or earlier).

 For that matter, your branch doesn't seem to fix anything that could have
 caused a crash ''inside'' `addressmap_get_virtual_address`, although your
 fixes are clearly a Good Thing.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2328#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online