[tor-bugs] #1795 [Tor Relay]: Prop 174: Optimistic Data for Tor: Server Side

[Tor Bug Tracker & Wiki]

#1795: Prop 174: Optimistic Data for Tor: Server Side
-------------------------+--------------------------------------------------
 Reporter:  nickm        |       Owner:  iang               
     Type:  enhancement  |      Status:  needs_review       
 Priority:  normal       |   Milestone:  Deliverable-Mar2011
Component:  Tor Relay    |     Version:                     
 Keywords:  prop174      |      Parent:  #1849              
-------------------------+--------------------------------------------------

Comment(by nickm):

 My point is that i see this patch making some SENDMEs conditional: these
 sendmes are sent from the exit towards the client in
 connection_edge_process_relay_cell when the exit receives a relay_data
 cell.  Your patch changes that, so that these cells are not sent if the
 relay_data cell that would have triggered them is an opportunistic cell.

 So are the two affected calls to circuit_consider_sending_sendme and
 connection_edge_consider_sending_sendme redundant, or no?  If they're
 redundant, we should maybe think about removing them.  If they're not,
 then this patch introduces a redundant bug.  If they're only sometimes
 redundant but sometimes needed, we should analyze better.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1795#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online