[tor-bugs] #2305 [Tor Client]: automake 1.6.3 leaves src/common/OpenBSD_malloc_Linux.c out of tarball

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Jan 3 22:05:24 UTC 2011


#2305: automake 1.6.3 leaves src/common/OpenBSD_malloc_Linux.c out of tarball
------------------------+---------------------------------------------------
 Reporter:  arma        |       Owner:  erinn             
     Type:  defect      |      Status:  new               
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 IMO we should just disallow the broken automakes; it seems much easier
 than trying to figure out what about our approach to conditional
 compilation plays badly with 1.6.

 Right now, AUTOMAKE_OPTIONS in Makefile.am says we support 1.6 and later.
 A quick check shows that 1.7 is the first one that distributes
 OpenBSD_malloc.c correctly, and the first one that doesn't give us all
 those warnings about --datarootdir.  I say we just update Makefile.am to
 say that we require 1.7 or later.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2305#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list