[tor-bugs] #1035 [Tor Relay]: Relay on dynamic IP marked as stable and guard

[Tor Bug Tracker & Wiki]

#1035: Relay on dynamic IP marked as stable and guard
--------------------------+-------------------------------------------------
    Reporter:  rudis      |       Owner:  Sebastian         
        Type:  defect     |      Status:  needs_review      
    Priority:  minor      |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Relay  |     Version:  0.2.0.35          
  Resolution:  None       |    Keywords:                    
      Parent:             |      Points:                    
Actualpoints:             |  
--------------------------+-------------------------------------------------

Comment(by nickm):

 I am liking this now.  I think it is good to merge.  I'll give others a
 day or two to look at it also.

 One subtle point is that now we must only call
 rep_hist_note_router_reachable() when the address of the router matches
 the one in the routerinfo we have.  (We do this.)  If we were to call it
 for addresses other than the listed address, then an attacker could do  an
 IP-forwarding MITM to make a node appear to be at two addresses in rapid
 succession over and over, thus hammering the node's apparent uptime.
 Maybe we should comment that.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1035#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online