[tor-bugs] #1968 [Torbutton]: window.name is persistent across websites

[Tor Bug Tracker & Wiki]

#1968: window.name is persistent across websites
-------------------------------------------------------------------+--------
 Reporter:  katmagic                                               |          Owner:  mikeperry       
     Type:  defect                                                 |         Status:  new             
 Priority:  blocker                                                |      Milestone:                  
Component:  Torbutton                                              |        Version:  Torbutton: 1.2.5
 Keywords:  TorbuttonIteration20110305 MikePerryIteration20110305  |         Parent:                  
   Points:  8                                                      |   Actualpoints:                  
-------------------------------------------------------------------+--------
Changes (by katmagic):

 * cc: the.magical.kat@… (added)


Comment:

 Replying to [comment:12 mikeperry]:
 > gk: Two reasons:
 >
 > 1. My understanding though is that the wrappedJSObject that window lives
 in has changed behaviors in FF3.5 -> FF4.0. So it requires some extra
 testing for each one.
 >
 > 2. We only want to reset this property if there has been a torbutton
 state change, I believe. Which means we need to find the relevant content
 window during the toggle phase, rather than the observer.
 >
 > We want to do this on Toggle because that is the codepath that is used
 for resetting browser state. I think we want to allow window.name to live
 for a single Tor session (or until the timer from #523 goes off).

 I'd definitely say that it should be reset every time a new domain is
 requested. I can't see any reason why someone would want it to persist
 between sites. It seems much cleaner to clear it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1968#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online