[tor-bugs] #1368 [Tor Client]: Implement a heartbeat log message

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Tue Feb 22 17:31:40 UTC 2011


#1368: Implement a heartbeat log message
--------------------------------+-------------------------------------------
 Reporter:  Sebastian           |           Type:  enhancement
   Status:  needs_review        |       Priority:  major      
Milestone:  Tor: 0.2.3.x-final  |      Component:  Tor Client 
  Version:  0.2.0.31            |     Resolution:             
 Keywords:                      |         Parent:             
   Points:                      |   Actualpoints:             
--------------------------------+-------------------------------------------

Comment(by nickm):

 Almost done!

 The comment on count_circuits() looks wrong: it returns the total number
 of circuits, not just the number of _open_ circuits.

 The comment on secs_to_uptime() is incomplete: by convention we mention
 when a function returns a _newly allocated_ string so that the caller
 knows to free it.

 The whitespace in bytes_to_bandwidth is a little wonky.

 I'll clean those up and merge to master.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1368#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list