[tor-bugs] #3729 [Pluggable transport]: obfsproxy rate limiting

[Tor Bug Tracker & Wiki]

#3729: obfsproxy rate limiting
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn         
     Type:  defect               |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:  #3591       
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by nickm):

 What happens if the rate is set but the burst is not? it looks like only
 the opposite case is configured.

 Converting strings to integers seems like it's part of the UI, and should
 probably happen in main or something, not network.

 The SET_RATE_LIMITING_VALUE macro should probably check for overflow.

 Otherwise looks okay.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3729#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online