[tor-bugs] #1827 [Tor Client]: binding a socket for 18.0.0.1 to learn our interface address is freaking out users

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Dec 22 16:18:03 UTC 2011


#1827: binding a socket for 18.0.0.1 to learn our interface address is freaking
out users
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by Sebastian):

 Some small review points:

 Maybe we should have unit tests for tor_addr_is_multicast()?

 I think you forgot a close(fd) in the if (ioctl(fd, SIOCGIFCONF, &ifc) <
 0) { case

 For the "if (sa->sa_family != AF_INET && sa->sa_family != AF_INET6)":
 above you comment that AF_INET6 isn't supported here, maybe if we do see
 it we should warn?

 please see branch bug1827 in my repo for a whitespace cleanup in
 configure.in and a fixup for documentation. Make sure that you didn't want
 to write more where I added a ".".

 Didn't have more questions/spot more issues on a quick go.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1827#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list