[tor-bugs] #4747 [Tor Relay]: getsockname in connection_handle_listener_read should be getpeername

[Tor Bug Tracker & Wiki]

#4747: getsockname in connection_handle_listener_read should be getpeername
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by asn):

 {{{
 < wanoskarnet> Every new bug (#4747) is the wrongly closed old ticket
 (#1240).
 ...
 < asn> wanoskarnet: nickm: the question is, can anything bad happen when
 filling 'remote' with the local address at that point? (#4747)
 < wanoskarnet> only spoofed logs. unless some comlicated nat configuration
 the it's leaves unlimited speed for link with poofed addr.
 < asn> If the connection can survive with the local address in conn->addr,
 connection_is_rate_limited() will indeed not consider it.
 }}}

 As wanoskarnet pointed out, 'r1eo' in #1240 was many months ahead of us.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4747#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online