[tor-bugs] #4722 [TorBrowserButton]: Rearranging tabs broken with Torbutton 1.4.5 on Windows

[Tor Bug Tracker & Wiki]

#4722: Rearranging tabs broken with Torbutton 1.4.5 on Windows
------------------------------+---------------------------------------------
 Reporter:  cypherpunks       |          Owner:  mikeperry
     Type:  defect            |         Status:  assigned 
 Priority:  major             |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:                    |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------

Comment(by cypherpunks):

 Replacing (flavor == "text/x-moz-url" || flavor == "text/x-moz-url-data"
 || flavor == "text/uri-list" || flavor == "application/x-moz-file-promise-
 url") with (0) makes no difference. Just removing aActionType = 0; fixes
 the problem, although I saw the following error in the Error console:

 Error: [Exception... "Component returned failure code: 0x80004005
 (NS_ERROR_FAILURE) [nsIDragService.invokeDragSessionWithImage]"  nsresult:
 "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
 jar:file:///[...]/components/external-app-blocker.js :: <TOP_LEVEL> ::
 line 251"  data: no]
 Source File: jar:file:///[...]/components/external-app-blocker.js
 Line: 251

 Where line 251 is:

 return this._drag().invokeDragSessionWithImage(aDOMNode,
 aTransferableArray, aRegion, aActionType, aImage, aImageX, aImageY,
 aDragEvent, aDataTransfer);

 I saw this error only once and couldn't reproduce it anymore.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4722#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online