[tor-bugs] #4727 [Tor Client]: Porting to Haiku (Patch increasing portability)

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Fri Dec 16 18:28:21 UTC 2011

#4727: Porting to Haiku (Patch increasing portability)
 Reporter:  martinhpedersen                  |          Owner:              
     Type:  enhancement                      |         Status:  needs_review
 Priority:  normal                           |      Milestone:              
Component:  Tor Client                       |        Version:              
 Keywords:  haiku porting gcc-3.3 lm libm m  |         Parent:              
   Points:                                   |   Actualpoints:              
Changes (by Sebastian):

  * status:  new => needs_review


 Thanks for the patches! Please don't be disconcerted at the below
 feedback, I really like your patch. If you won't have time to do what I
 suggest, I'll gladly do it!

 First off, please change the status of a trac ticket to "needs review"
 when you have some code. That helps us find things we should look at
 quickly :)

 For the first patch, can you please update it to preserve order of libs?
 We've had tons of trouble before where on some platforms the order was
 significant, which led to hard to track down bugs, particularly on
 windows. I'm unsure if that is the case here, but it might well be, so
 better safe than sorry :)

 As a general note, we try to keep the first line of a commit message
 pretty short. If you can think of a better msg in 10 seconds, please
 update it. Otherwise, just keep it this way, it's not that big a deal.
 Also, if you want, you could add the changes/ files that we like to do
 (see doc/HACKING for how to do it, or ask on irc).

 Thanks again!

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4727#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list