[tor-bugs] #4677 [Tor Relay]: master won't build without V2_HANDSHAKE_SERVER

[Tor Bug Tracker & Wiki]

#4677: master won't build without V2_HANDSHAKE_SERVER
-----------------------+----------------------------------------------------
 Reporter:  asn        |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  minor      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 master won't build without `V2_HANDSHAKE_SERVER`:
 {{{
 tortls.c:1525:40: error: ‘tor_tls_debug_state_callback’ undeclared (first
 use in this function)
 tortls.c:1525:40: note: each undeclared identifier is reported only once
 for each function it appears in
 }}}

 This happens because without `V2_HANDSHAKE_SERVER`,
 `tor_tls_debug_state_callback` is not defined and it's not visible when
 `tor_tls_new()`  tries to do:
 {{{
  SSL_set_info_callback(result->ssl, tor_tls_debug_state_callback);
 }}}

 This bug was introduced in `410e440a8d40e556cc445a1ecc6a8ed4109434b6`, and
 simply always defining `tor_tls_debug_state_callback` (and not only when
 V2_HANDSHAKE_SERVER`) should fix it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4677>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online