[tor-bugs] #1983 [Tor Relay]: Port tor-fw-helper to Windows

[Tor Bug Tracker & Wiki]

#1983: Port tor-fw-helper to Windows
-------------------------+--------------------------------------------------
 Reporter:  ioerror      |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  major        |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |        Version:  Tor: unspecified  
 Keywords:               |         Parent:  #1775             
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by sjmurdoch):

  * status:  new => needs_review


Comment:

 The patch to build tor-fw-helper on Windows is ready for review (but not
 merge: it breaks on non-Windows platforms). I would like to know how best
 to make it cross-platform.

 The patch is 2ad336f999781db211d92332e657398829c8799c in
 git://git.torproject.org/sjm217/tor.git (branch bug1983-port-tor-fw-
 helper-to-windows)

 Build using:
 {{{
 ./autogen.sh
 ./configure --enable-upnp --enable-gcc-warnings --disable-asciidoc --with-
 libminiupnpc-dir=/local/lib
 }}}

 Oddly, while I specified miniupnpc to be searched for in /local/lib, the
 Makefile looks for it in /usr/local/lib. The two directories are actually
 the same one, but I'm not sure why this is happening.

 {{{
 gcc  -g -O2 -Wall -fno-strict-aliasing -W -Wfloat-equal -Wundef -Wpointer-
 arith
 -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls
 -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wmissing-
 declarations
 -Wredundant-decls -Wnested-externs -Wbad-function-cast -Wswitch-enum
 -Werror
 -Winit-self -Wmissing-field-initializers -Wdeclaration-after-statement
 -Wold-style-definition -Waddress -Wmissing-noreturn -Wstrict-overflow=1
 -Wnormalized=id -Woverride-init -Wextra -Warray-bounds  -L/usr/local/lib
 -Wl,--nxcompat -Wl,--dynamicbase -o tor-fw-helper.exe tor_fw_helper-tor-
 fw-helper.o
 tor_fw_helper-tor-fw-helper-natpmp.o tor_fw_helper-tor-fw-helper-upnp.o
 ../../common/libor.a  -lminiupnpc -lm-liphlpapi -lws2_32
 }}}

 Another question is that I get the following warning. Is this OK?
 {{{
 Warning: resolving _getaddrinfo by linking to _getaddrinfo at 16
 Use --enable-stdcall-fixup to disable these warnings
 Use --disable-stdcall-fixup to disable these fixups
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1983#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online