#1692: No Events for SETCONF
-------------------------+--------------------------------------------------
Reporter: atagar | Owner: krkhan
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: unspecified
Component: Tor Relay | Version: Tor: unspecified
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by rransom):
Replying to [comment:16 krkhan]:
> Added the changes file.
>
> *
[https://github.com/krkhan/tor/commit/3b85fe8a5dd0fed88163ffc3bcb4eec8bf2053bc
Commit]
> * [https://github.com/krkhan/tor/compare/bug1692 Tor patch]
>
> Since the values don't contain CRLFs, I don't think they need to be
escaped.
Yes, they do. (Option values might contain quotation marks, for example.)
Use either `esc_for_log` or `escaped`.
Also, consider cherry-picking 4051fcf0d6bc27b51c6910ec8ff0dc704005752a and
5628256a525a6838c176b8affbea790f1c62de6f from my bug3632-debug-v2 branch
(and squashing them into a single commit). `smartlist_asprintf_add` will
make your code even more readable.
Also, please move the code that constructs a key-value list into
`control_event_conf_changed` -- that function should take as its arguments
the old and new `or_options_t` structures, and only make a list of the
options that changed if some control-port client actually wants a
`CONF_CHANGED` event.
Also, we don't want tab characters in Tor's source code -- in the future,
please run ‘`make check-spaces`’ to check for them.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1692#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online