[tor-bugs] #1692 [Tor Relay]: No Events for SETCONF

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Aug 8 13:39:35 UTC 2011

#1692: No Events for SETCONF
 Reporter:  atagar       |          Owner:  krkhan          
     Type:  enhancement  |         Status:  needs_review    
 Priority:  normal       |      Milestone:  Tor: unspecified
Component:  Tor Relay    |        Version:  Tor: unspecified
 Keywords:               |         Parent:                  
   Points:               |   Actualpoints:                  

Comment(by nickm):

 The Tor patch logic looks okay, but the factoring is a little iffy for two

 * The CONTROL_PRIVATE define is only supposed to be defined for access to
 private members of control.h -- only control.c and unit tests are supposed
 to do that.

 * In general, only control.c is supposed to understand how to format
 controller messages, so the translation from config_line_t to a bunch of
 lines in a controller message should probably happen there.

 Also, it needs a changes file.  seems okay other than that.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1692#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list