[tor-bugs] #3613 [Pluggable transport]: obfsproxy: groundwork for new protocols

[Tor Bug Tracker & Wiki]

#3613: obfsproxy: groundwork for new protocols
---------------------------------+------------------------------------------
 Reporter:  zwol                 |          Owner:  asn         
     Type:  enhancement          |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:              
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by asn):

 Alright, I think I'm now up to date with all the design changes till
 19eda9f8.
 I'll now start looking at x_http and x_dsteg.

 BTW, we should probably decide on code style, before we bastardize the
 whole code base. For example, connections.c functions are now commented on
 the header file. I don't like this [0], but if we decide to keep it like
 this, we should migrate the rest of the code as well.

 obfs2 must be revived before merging your stuff. It serves as a nice basic
 transport example. I rolled back to 674d0735 and manually tested obfs2 and
 it seems to work.
 I also used the old int_test.sh on it, and it worked nicely. I'm not sure
 why it doesn't work on tester.py; I haven't checked the code of
 tester.py.in that much.

 I have a bug3613_shutdown branch in my repo which fixes a small issue
 while shutting down obfsproxy barbarically.

 Thanks for your work!

 [0]: I enjoy easily viewing the function documentation while checking out
 a function's code.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3613#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online