[tor-bugs] #3035 [Tor Client]: fix a few clang-static analyzer complaints in 0.2.2

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Apr 28 22:27:05 UTC 2011


#3035: fix a few clang-static analyzer complaints in 0.2.2
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
    memset(addrbuf,0,sizeof(addrbuf));
 -  dest_addr = (struct sockaddr*) addrbuf;
    dest_addr_len = tor_addr_to_sockaddr(addr, port, dest_addr,
 sizeof(addrbuf));
 }}}

 looks fine, but Nick may prefer (for readability) to actually remove the
 first time we assign to it, rather than this time. I'll leave that up to
 Nick.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3035#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list