[tor-bugs] #3035 [Tor Client]: fix a few clang-static analyzer complaints in 0.2.2

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Apr 28 22:22:12 UTC 2011


#3035: fix a few clang-static analyzer complaints in 0.2.2
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
 +      if (cur && (cur_n > most_n ||
 +          (cur_n == most_n && cur->status.published_on >
 most_published))) {
 }}}
 would be more readable formatted as
 {{{
 +      if (cur && (cur_n > most_n ||
 +                  (cur_n == most_n &&
 +                   cur->status.published_on > most_published))) {
 }}}

 We try to line up the parts of the clause that are grouped by the parens.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3035#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list