[tor-bugs] #1090 [Tor Client]: Warning about using an excluded node for exit

[Tor Bug Tracker & Wiki]

#1090: Warning about using an excluded node for exit
---------------------------+------------------------------------------------
    Reporter:  Sebastian   |       Owner:  nickm             
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  0.2.1.19          
  Resolution:  None        |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by arma):

 Replying to [comment:53 nickm]:
 > I'm a little worried about the case where we re-fetch the descriptor
 based on having all our intro nodes excluded.  If they were excluded to
 begin with, there's no point refetching the descriptor forever in an
 infinite loop.  Is there something to stop that?  I wrote up an
 implementation of the thing you suggest in branch
 "bug1090-intro_point_exclude", but I think it's broken for that reason.

 Ha. It turns out there is a thing to stop the infinite downloads:
 {{{
 /** Determine the responsible hidden service directories for
 <b>desc_id</b>
  * and fetch the descriptor belonging to that ID from one of them. Only
  * send a request to hidden service directories that we did not try within
  * the last REND_HID_SERV_DIR_REQUERY_PERIOD seconds; on success, return
 1,
  * in the case that no hidden service directory is left to ask for the
  * descriptor, return 0, and in case of a failure -1. <b>query</b> is only
  * passed for pretty log statements. */
 static int
 directory_get_from_hs_dir(const char *desc_id, const rend_data_t
 *rend_query)
 }}}

 It only tries any given hidden service directory at most every 15 minutes.
 See also #997.

 I can't say it's super elegant, but I bet it'll do for now. We should then
 put this topic on the plate of hidserv things that rransom should take a
 closer look at.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1090#comment:73>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online