[tor-bugs] #3000 [Tor Client]: Clients do not clear HS descriptor cache on SIGNAL NEWNYM

[Tor Bug Tracker & Wiki]

#3000: Clients do not clear HS descriptor cache on SIGNAL NEWNYM
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by rransom):

  * status:  new => needs_review


Comment:

 Replying to [comment:1 nickm]:
 > Seems like an easy fix; are you working on a patch here?

 Writing a fix for this took most of the last week.  Making NEWNYM nuke the
 HS descriptor cache was trivial; making it cancel whatever HS descriptor
 fetches are in progress required only a little thought.  Cleaning up the
 mess that nuking the descriptor cache made was a PITA.

 See [http://repo.or.cz/w/tor/rransom.git/shortlog/refs/heads/bug3000-021
 bug3000-021] ( !ssh://mob@repo.or.cz/srv/git/tor/rransom.git bug3000-021 )
 for a branch on maint-0.2.1; see
 [http://repo.or.cz/w/tor/rransom.git/shortlog/refs/heads/bug3000-022
 bug3000-022] ( !ssh://mob@repo.or.cz/srv/git/tor/rransom.git bug3000-022 )
 for a branch on maint-0.2.2.  The merges were non-trivial, and need to be
 reviewed carefully.

 I also put a fix for #1930 (also known as #1024) on this branch, mainly
 because I didn't figure out that nuking the HS descriptor cache more often
 wouldn't cause #1930 to occur more often until after I had written that
 fix.

 This branch ''will'' need to be merged to maint-0.2.1.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3000#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online