[tor-bugs] #1090 [Tor Client]: Warning about using an excluded node for exit

[Tor Bug Tracker & Wiki]

#1090: Warning about using an excluded node for exit
---------------------------+------------------------------------------------
    Reporter:  Sebastian   |       Owner:  nickm             
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  0.2.1.19          
  Resolution:  None        |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by arma):

 {{{
 +        if (options->ExcludeNodes) {
 +          /* Make sure no existing nodes in the circuit is excluded for
 +           * general use.  (This is possible if StrictNodes is 0, and we
 +           * thought we needed to use an otherwise excluded node for,
 say, a
 +           * directory operation.) */
 +          crypt_path_t *hop = circ->cpath;
 +          do {
 +            if (routerset_contains_extendinfo(options->ExcludeNodes,
 +                                              hop->extend_info))
 +              goto next;
 +          } while (hop != circ->cpath);
 +        }
 }}}

 A) "is excluded" -> "are excluded"

 B) Is this situation really possible? What are these directory operations
 that alter our path selection for general open non-dirty circuits? But
 that said, it looks fine as a defensive step.

 C) This is an infinite loop. You want a hop=hop->next somewhere.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1090#comment:67>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online