[tor-bugs] #2971 [Tor Client]: Tor doesn't expand ~ in Log config options

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Apr 25 22:26:37 UTC 2011


#2971: Tor doesn't expand ~ in Log config options
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:  Sebastian         
     Type:  defect      |         Status:  needs_review      
 Priority:  minor       |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Wow, that's a pretty broad approach.  I wonder if it's safe.  Have we
 audited all the callers of read_file_to_str for potential issues?  What
 about places where we open files with some other means; will we break
 stuff there?  What about write_str_to_file; will we read stuff from one
 place but write it to another?

 For 0.2.2, I'm much more inclined to simply take the Log part of the
 patch, and postpone more tweaks here to 0.2.3, possibly trying to address
 this at a higher level (config.c rather than util.c).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2971#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list