[tor-bugs] #1090 [Tor Client]: Warning about using an excluded node for exit

[Tor Bug Tracker & Wiki]

#1090: Warning about using an excluded node for exit
---------------------------+------------------------------------------------
    Reporter:  Sebastian   |       Owner:  nickm             
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  0.2.1.19          
  Resolution:  None        |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by Sebastian):

 The fixups look good.

 For the refetching of descriptors, we'd need some kind of logic to check
 that we don't refetch a descriptor if the one we have looks recent and
 there are no other events that might cause us to like it now (we got a new
 consensus).

 As for reviewing that commit, it looks like in
 rend_client_get_random_intro_impl() you wanted that warnings argument to
 get rid of the StrictNodes check inside (which is a good thing), but then
 neither documented it nor actually got rid of the StrictNodes check.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1090#comment:54>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online