[tor-bugs] #2105 [Vidalia]: Pick up the breakpad integration

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Wed Apr 20 23:32:09 UTC 2011


#2105: Pick up the breakpad integration
-------------------------+--------------------------------------------------
 Reporter:  arma         |          Owner:  chiiph       
     Type:  enhancement  |         Status:  assigned     
 Priority:  major        |      Milestone:  Vidalia-0.3.X
Component:  Vidalia      |        Version:               
 Keywords:               |         Parent:               
   Points:               |   Actualpoints:               
-------------------------+--------------------------------------------------

Comment(by edmanm):

 So a couple of comments:

 1) The fact that I did not use Qt API methods for stuff in the exception
 handler is 'absolutely' intentional. When the minidump callback is called,
 the application is probably in a bad state and so you want to do as little
 as necessary in the handler. Calling out to complex, unnecessary
 libraries, such as Qt, is not a good idea.

 2) You broke crash dump support on Windows systems using wide chars
 (unless something has significantly changed in recent versions of
 Breakpad).

 3) I don't think this does what you think it does:

 {{{
 -  target_link_libraries(${vidalia_BIN} ${BREAKPAD_LIBRARIES})
 +  target_link_libraries(${vidalia_BIN} ${BREAKPAD_LIBRARY_DIR})
 }}}

 You're trying to link a binary to a directory, rather than the actual
 libraries (unless you define `BREAKPAD_LIBRARY_DIR` to a specific file
 rather than a directory to search for the correct files, but that's
 nonsense). See `FindBreakpad.cmake`.

 4) I don't understand this:

 {{{
 +  _configDialog = 0;
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2105#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list