[tor-bugs] #2954 [Tor Directory Authority]: ides corrupted its cached-microdescs.new file

[Tor Bug Tracker & Wiki]

#2954: ides corrupted its cached-microdescs.new file
----------------------------------------+-----------------------------------
    Reporter:  mikeperry                |       Owner:  nickm             
        Type:  defect                   |      Status:  assigned          
    Priority:  normal                   |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Directory Authority  |     Version:                    
  Resolution:                           |    Keywords:                    
      Parent:                           |      Points:                    
Actualpoints:                           |  
----------------------------------------+-----------------------------------

Comment(by cypherpunks):

 Replying to [ticket:2954 mikeperry]:
 > corrupted its cached-microdescs.new file

 It's impossible by Tor itself.
 {{{
     f = start_writing_to_stdio_file(cache->journal_fname,
                                     OPEN_FLAGS_APPEND|O_BINARY,
                                     0600, &open_file);
 }}}
 cached-microdescs could be broken during calls of
 microdesc_cache_rebuild().

 microdesc_cache_clean() happens during rebuild only, so every old md
 storing until then.

 #2230 and
 {{{
 finish_writing_to_file(open_file); /*XXX Check me.*/
 }}}
 is reasons of OOM and corruptions.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2954#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online