[tor-bugs] #2704 [Tor Relay]: BandwidthObserved higher than BandwidthBurst

[Tor Bug Tracker & Wiki]

#2704: BandwidthObserved higher than BandwidthBurst
-----------------------------------------------+----------------------------
 Reporter:  keb                                |          Owner:  Sebastian          
     Type:  defect                             |         Status:  needs_review       
 Priority:  major                              |      Milestone:  Tor: 0.2.2.x-final 
Component:  Tor Relay                          |        Version:  Tor: 0.2.2.23-alpha
 Keywords:  0.2.2.23-alpha bandwidth observed  |         Parent:                     
   Points:                                     |   Actualpoints:                     
-----------------------------------------------+----------------------------

Comment(by nickm):

 We ran into a bug on IRC:

 >18:56 < nickm> hang on.  That loop, where we do "while (start < now)".
 Is that
 >               right?  If this interval is not the most recent one, then
 won't
 >               we add the observation far too many times?

 and a simplification:


 > 18:57 < nickm> also you can simplify the overflow logic a lot
 > 18:57 < nickm> instead of overflow, have, say,  "actual_interval_len".
 Set it
 >               to either s_interval or to now-start.
 > 18:57 < nickm> then compute cur = v / actual_interval_len

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2704#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online