[tor-bugs] #2781 [Torbutton]: Review Robert Hogan's WebKit patches

[Tor Bug Tracker & Wiki]

#2781: Review Robert Hogan's WebKit patches
-------------------------------------------------------------------+--------
 Reporter:  mikeperry                                              |          Owner:  mikeperry
     Type:  task                                                   |         Status:  new      
 Priority:  normal                                                 |      Milestone:           
Component:  Torbutton                                              |        Version:           
 Keywords:  MikePerryIteration20110403 TorbuttonIteration20110403  |         Parent:           
   Points:  3                                                      |   Actualpoints:           
-------------------------------------------------------------------+--------

Comment(by mikeperry):

 Ok, I guess I'll write up my thoughts here. I'm unfamiliar with webkit, so
 I'm first going to state my assumptions of what I think the code is trying
 to do.

 First off, it looks like the primary use of these APIs is for C++ front
 ends implementing the ChromeClient interface, right? So each
 implementation would have to re-implement the QWebUserEnvironment
 interface in order to get their versions called by ChromeClient?

 What was the discussion about Private APIs about? What is the difference
 between public and private APIs? Are private APIs only available to C++?

 Does WebKit also provide window.screen.*? In Firefox, those values mirror
 a lot of the top level values here, including desktop resolution.

 Also, I do not see you doing anything about screenX, screenY, and
 page[XY]Offset. You only appear to touch scrollX and Y? Is there a reason
 for this?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2781#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online