[tor-bugs] #1963 [Tor Relay]: Make tor-fw-helper summarize success status

[Tor Bug Tracker & Wiki]

#1963: Make tor-fw-helper summarize success status
--------------------------+-------------------------------------------------
  Reporter:  sjmurdoch    |       Owner:        
      Type:  task         |      Status:  closed
  Priority:  normal       |   Milestone:        
 Component:  Tor Relay    |     Version:        
Resolution:  implemented  |    Keywords:        
    Parent:  #1900        |  
--------------------------+-------------------------------------------------
Changes (by ioerror):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 I've included the current output for two helpers currently supported by
 tor-fw-helper (all of this is on stdout because it lacks errors):
 {{{
 ./tor-fw-helper -g
 tor-fw-helper: UPnP GetValidIGD returned: 1 (SUCCESS)
 tor-fw-helper: natpmp init...
 tor-fw-helper: 2 NAT traversal helper(s) loaded
 tor-fw-helper: ExternalIPAddress = 1.2.3.4
 tor-fw-helper: tor_fw_fetch_public_ip backend miniupnp returned: 0
 tor-fw-helper: NAT-PMP sendpublicaddressrequest returned 2 (SUCCESS)
 tor-fw-helper: ExternalIPAddress = 1.2.3.4
 tor-fw-helper: tor_fw_fetch_public_ip backend natpmp returned: 0
 tor-fw-helper: SUCCESS
 }}}

 This is an example of a port mapping request:
 {{{
 ./tor-fw-helper -i 20564
 tor-fw-helper: UPnP GetValidIGD returned: 1 (SUCCESS)
 tor-fw-helper: natpmp init...
 tor-fw-helper: 2 NAT traversal helper(s) loaded
 tor-fw-helper: tor_fw_add_or_port backend miniupnp returned: 0
 tor-fw-helper: NAT-PMP mapped public port 20564 to localport 20564 liftime
 3600
 tor-fw-helper: tor_fw_add_or_port backend natpmp returned: 0
 tor-fw-helper: SUCCESS
 }}}

 If this isn't OK, please re-open this bug and let me know.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1963#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online