[tor-bugs] #1366 [Tor Relay]: reload of valid but changed config causes abort

[Tor Bug Tracker & Wiki]

#1366: reload of valid but changed config causes abort
----------------------------+-----------------------------------------------
 Reporter:  keb             |         Type:  defect   
   Status:  new             |     Priority:  trivial  
Milestone:                  |    Component:  Tor Relay
  Version:  0.2.2.11-alpha  |   Resolution:  None     
 Keywords:                  |       Parent:           
----------------------------+-----------------------------------------------

Old description:

> changed the DirReqStatistics value in torrc and sent a HUP to the running
> Tor:
>
> Apr 20 00:50:32.776 [notice] Received reload signal (hup). Reloading
> config and resetting internal state.
> Apr 20 00:50:32.778 [warn] Failed to parse/validate config: While Tor is
> running,
>   changing either CellStatistics, DirReqStatistics, EntryStatistics, or
> ExitPortStatistics is not allowed.
> Apr 20 00:50:32.778 [err] Reading config failed--see warnings above. For
> usage, try -h.
> Apr 20 00:50:32.778 [warn] Restart failed (config error?). Exiting.
>
> behaviour seems ornery.
> if changing one of those Stats config vars is not allowed while running,
> then shouldnt it keep running with current values
> and refuse to continue reloading the config?
> if it is going to quit anyway, why not restart and load the new (valid)
> config?
>

> [Automatically added by flyspray2trac: Operating System: All]

New description:

 changed the DirReqStatistics value in torrc and sent a HUP to the running
 Tor:

 Apr 20 00:50:32.776 [notice] Received reload signal (hup). Reloading
 config and resetting internal state.
 Apr 20 00:50:32.778 [warn] Failed to parse/validate config: While Tor is
 running,
   changing either CellStatistics, DirReqStatistics, EntryStatistics, or
 ExitPortStatistics is not allowed.
 Apr 20 00:50:32.778 [err] Reading config failed--see warnings above. For
 usage, try -h.
 Apr 20 00:50:32.778 [warn] Restart failed (config error?). Exiting.

 behaviour seems ornery.
 if changing one of those Stats config vars is not allowed while running,
 then shouldnt it keep running with current values
 and refuse to continue reloading the config?
 if it is going to quit anyway, why not restart and load the new (valid)
 config?


 [Automatically added by flyspray2trac: Operating System: All]

--

Comment(by arma):

 Karsten changed these particular config options to be changeable on the
 fly:

 Changes in version 0.2.2.15-alpha - 2010-08-18
 [...]
   o Major features:
 [...]
     - Allow enabling or disabling the *Statistics config options while
       Tor is running.

 So this particular issue should be solved now.

 More generally, check out the tor --verify-config command-line option that
 you should use to validate your torrc before attempting a hup. The debian
 tor package uses this feature.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1366#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online