[tor-bugs] #1981 [Tor Client]: when your bridges go down, you don't optimistically retry

[Tor Bug Tracker & Wiki]

#1981: when your bridges go down, you don't optimistically retry
------------------------+---------------------------------------------------
 Reporter:  arma        |       Owner:  arma              
     Type:  defect      |      Status:  new               
 Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by arma):

 The problem is that we don't ever tell ourselves that the entry guard
 connection has succeeded. So when learned_bridge_descriptor() says:
 {{{
 Sep 28 16:32:58.886 [notice] new bridge descriptor 'bridge' (fresh)
 }}}
 it calls
 {{{
 add_an_entry_guard(ri, 1);
 }}}
 but nothing sets entry->made_contact, which means when the network or
 bridge goes away and we try a connection to the bridge and fail, we get:
 {{{
 Sep 28 14:40:58.195 [info] entry_guard_register_connect_status():
 Connection to never-contacted entry guard 'bridge'
 (4C17FB532E20B2A8AC199441ECD2B0177B39E4B1) failed. Removing from the list.
 -1/0 entry guards usable/new.
 }}}
 and now the entry node is gone, which means bridges_retry_helper() will
 say
 {{{
 Sep 28 15:34:43.136 [debug] bridges_retry_helper(): any_known 0,
 any_running 0
 }}}
 because there are no entry guards configured at all.

 So bridges_known_but_down() returns 0.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1981#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online