[tor-bugs] #1933 [Tor Relay]: GETINFO requests trigger conn_read_callback events

[Tor Bug Tracker & Wiki]

#1933: GETINFO requests trigger conn_read_callback events
-----------------------+----------------------------------------------------
 Reporter:  atagar     |       Owner:     
     Type:  defect     |      Status:  new
 Priority:  minor      |   Milestone:     
Component:  Tor Relay  |     Version:     
 Keywords:             |      Parent:     
-----------------------+----------------------------------------------------

Comment(by nickm):

 Well, the log message is _correct_: the controller wrote the GETINFO
 command to the control socket, which caused the kernel to tell Tor, "Hey,
 socket 15 is now readable", so Tor has wound up in conn_read_callback
 (thanks to Libevent), and it is ready to read what the controller told it.

 So the next question is, "Is it intentional that controllers can get DEBUG
 log messages that are caused by their own actions?"  I think that's a
 "yes" too.  The only case where we have deliberately stopped that from
 happening is in the CONN_LOG_PROTECT() cases in connection.c, which we
 added because we wanted to avoid infinite loops where sending a DEBUG
 message to a controller counted as a write an in turn caused other debug
 messages to get logged and sent to the controller.

 It is certainly as-designed that the DEBUG log level is "kinda noisy".

 So the last questions is, is there some reason the current behavior is
 incorrect?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1933#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online