[tor-bugs] #1992 [Tor Relay]: relays resolve hostname every time they compute dir fetch schedule; but bridges resolve too seldom

[Tor Bug Tracker & Wiki]

#1992: relays resolve hostname every time they compute dir fetch schedule; but
bridges resolve too seldom
-----------------------+----------------------------------------------------
 Reporter:  arma       |       Owner:                    
     Type:  defect     |      Status:  needs_review      
 Priority:  minor      |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:             |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Looks ok except for some really trivial things:
  * the 'tmpbuf' thing doesn't necessarily get freed; I think there are
 some paths out of that function without calling tor_free(tmpbuf).
  * 'tmpbuf' is no longer a good name for it
  * The documentation for anything that takes a uint32_t as an IP address
 needs to be explicit about whether it wants one in host or network order.
 I personally prefer saying "format_addr_ipv4h" instead to be explicit.

 I can clean up the above stuff and merge.  Then we should do another grep
 for INET_NTOA_BUF_LEN to look for other places that might want converting.

 Still trivial, not worth fixing here
  * I wish we had a naming convention for things that do the "return a
 pointer that the next call to this function will invalidate; VERY
 NONENTRANT" pattern.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1992#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online