[tor-bugs] #2205 [Tor Relay]: private network of nodes running master doesn't allow client requests to complete

[Tor Bug Tracker & Wiki]

#2205: private network of nodes running master doesn't allow client requests to
complete
-----------------------+----------------------------------------------------
 Reporter:  Sebastian  |       Owner:                    
     Type:  defect     |      Status:  new               
 Priority:  major      |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:             |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by cypherpunks):

 _Version №1_

 {{{
           /* improved handshake, but not a client. */
           tor_tls_set_renegotiate_callback(conn->tls,
 connection_or_tls_renegotiated_cb,
                                            conn);
           conn->_base.state = OR_CONN_STATE_TLS_SERVER_RENEGOTIATING;
           connection_stop_writing(TO_CONN(conn));
           connection_start_reading(TO_CONN(conn));
 }}}
 Wait for reneg.

 happened: connection_handle_read().
 going: connection_read_to_buf(),read_to_buf_tls():
 (lets assume handshake state already was SSL3_ST_SW_SRVR_HELLO_A, so
 tor_tls_server_info_callback() set tls->got_renegotiate = 1. and now state
 is SSL3_ST_SR_CERT_A)

 Handshake after reneg still is incomplete.

 connection_process_inbuf(conn, 1),
 connection_or_process_inbuf(TO_OR_CONN(conn)):
 {{{
     case OR_CONN_STATE_TLS_SERVER_RENEGOTIATING:
       if (tor_tls_server_got_renegotiate(conn->tls))
         connection_or_tls_renegotiated_cb(conn->tls, conn);
 }}}
 connection_tls_finish_handshake(conn):
 {{{
     if (!started_here) {
       connection_or_init_conn_from_address(conn, &conn->_base.addr,
                                            conn->_base.port, digest_rcvd,
 0);
 }}}
 connection_or_set_identity_digest(conn, id_digest),
 No client-side cert, zeroes inside id_digest.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2205#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online