[tor-bugs] #2191 [Tor Client]: Send all error-level log messages to controllers

[Tor Bug Tracker & Wiki]

#2191: Send all error-level log messages to controllers
--------------------------------+-------------------------------------------
 Reporter:  rransom             |        Type:  defect    
   Status:  new                 |    Priority:  major     
Milestone:  Tor: 0.2.2.x-final  |   Component:  Tor Client
  Version:                      |    Keywords:            
   Parent:                      |  
--------------------------------+-------------------------------------------

Comment(by nickm):

 Hmm.  The CRLF "." CRLF would tend to make our existing controller grammar
 pretty much bunk, and would also make it hard to tell a truncated data
 chunk from a completed one.

 How about if we used a character otherwise forbidden in the controller
 grammar, like ESC?  That way we can change the grammar from :
 {{{
   Reply = SyncReply / AsyncReply
 }}}
 to
 {{{
   Reply = SyncReply / AsyncReply / ( TruncatedReply Error )

   TruncatedReply = TruncatedReplyLine / TruncatedData

   TruncatedReplyLine = ReplyText ESC ESC CRLF
   TruncatedData = (define this)

   Error = STATUSCODE SP "ERROR" [SP "ReplyText"] CRLF [Data]
 }}}

 Of course, we'd still need to use the USEFEATURE trick.  And I note that
 ReplyText isn't defined right now, so we'll need to think about that too.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2191#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online