[tor-bugs] #2189 [Tor Client]: Control Protocol Specification Error -- circuit-status grammar incorrect.

[Tor Bug Tracker & Wiki]

#2189: Control Protocol Specification Error -- circuit-status grammar incorrect.
---------------------------------+------------------------------------------
 Reporter:  Poet                 |        Type:  defect    
   Status:  new                  |    Priority:  minor     
Milestone:  Tor: 0.2.2.x-final   |   Component:  Tor Client
  Version:  Tor: 0.2.2.17-alpha  |    Keywords:            
   Parent:                       |  
---------------------------------+------------------------------------------

Comment(by Poet):

 Hi, I have just added 3 patches related to this issue.

 (1) The a patch to the description of USEFEATURE. I noticed while fixing
 the original problem that the descriptions of features is not as clear as
 it could be. nickm and I discussed this briefly on IRC.

 `19:34 < poet> also I am wondering, once a feature is enabled by default
 is it impossible to turn off`

 `19:35 < poet> through a configuration option that is (obviously you can
 recompile)`

 `19:35 `< nickm> I believe that is so.  There is no DONT_USEFEATURE

 !19:35 < nickm> Best practice is probably just to USEFEATURE both the
 known features always.

 !19:35 < poet> Ok

 !19:36 < nickm> Versions of Tor that do not have them are absolete and
 nonworking, and we haven't introduced a new one since 0.1.2

 !19:36 < poet> the feature section of the control spec uses both "always-
 on" and "on by default", so I figured it could be clearer

 !19:36 < poet> ah

 !19:37 < nickm> "always on" is probably the better phrase

 !19:37 < poet> ok

 (2) A patch to general use tokens to make it more clear that ServerID is
 no longer in use.

 (3) The actual fixes discussed in the original bug report. Changes to the
 grammars of events and GETINFO responses in order to reflect the fact that
 VERBOSE_NAMING is a part of the protocol now.

 I appreciate any comments and criticisms!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2189#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online