[tor-bugs] #2191 [Tor Client]: Send all error-level log messages to controllers

[Tor Bug Tracker & Wiki]

#2191: Send all error-level log messages to controllers
--------------------------------+-------------------------------------------
 Reporter:  rransom             |        Type:  defect    
   Status:  new                 |    Priority:  major     
Milestone:  Tor: 0.2.2.x-final  |   Component:  Tor Client
  Version:                      |    Keywords:            
   Parent:                      |  
--------------------------------+-------------------------------------------
 Right now, if:
  * an assertion fails inside Tor,
  * Tor has disabled sending log messages to its controllers, and
  * Tor is not logging directly to syslog or any file descriptors,
 Tor will crash silently, with no record anywhere of why it crashed.  This
 is especially bad for users of the Tor Browser Bundles and Vidalia
 Bundles, which are preconfigured to not log to disk.

 Tor should:
  * only log error-level messages when a crash is imminent (e.g. in
 `tor_assert`),
  * send log messages to all non-callback log sinks before sending them to
 callbacks, and
  * send error-level log messages to controllers regardless of whether
 logging to controllers is otherwise disabled (with the
 `disable_control_logging` function or a wrapper around it).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2191>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online