[tor-bugs] #2183 [Tor Relay]: router_rebuild_descriptor(): Bug: Couldn't generate extra-info descriptor

[Tor Bug Tracker & Wiki]

#2183: router_rebuild_descriptor(): Bug: Couldn't generate extra-info descriptor
-----------------------+----------------------------------------------------
 Reporter:  Falo       |       Owner:  karsten            
     Type:  defect     |      Status:  needs_review       
 Priority:  normal     |   Milestone:                     
Component:  Tor Relay  |     Version:  Tor: 0.2.2.17-alpha
 Keywords:             |      Parent:                     
-----------------------+----------------------------------------------------

Comment(by karsten):

 Replying to [comment:12 rransom]:
 > See
 [http://repo.or.cz/w/tor/rransom.git/shortlog/refs/heads/mitigate2183
 mitigate2183] ( !git://repo.or.cz/tor/rransom.git mitigate2183 ) for
 patches to make relays generate (and publish) router descriptors even if
 they cannot generate their extra-info descriptors.

 I think the approach to publish a router descriptor even if we cannot
 generate an extra-info descriptor is good.

 A quick comment to your patch: You could add a parameter
 has_extra_info_digest to router_dump_router_to_string() instead of
 iterating over all bytes of extra_info_digest to find out if it contains a
 non-zero value.

 Also, how about using a new variable for the extra-info-digest line
 instead of the "%s%s%s%s" part? Other than that, looks good.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2183#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online