[tor-bugs] #1291 [Tor Relay]: Relays that aren't Valid never get Running

[Tor Bug Tracker & Wiki]

#1291: Relays that aren't Valid never get Running
--------------------------------+-------------------------------------------
 Reporter:  arma                |         Type:  defect   
   Status:  new                 |     Priority:  minor    
Milestone:  Tor: 0.2.3.x-final  |    Component:  Tor Relay
  Version:  0.2.1.22            |   Resolution:  None     
 Keywords:                      |       Parent:           
--------------------------------+-------------------------------------------
Changes (by nickm):

  * milestone:  => Tor: 0.2.3.x-final


Old description:

> We use router_is_active() for too many checks when directory authorities
> are
> deciding how to handle relays that don't have the Valid flag.
>
> Once upon a time, you could be missing a Valid flag and still get the
> Running
> flag. That would cause clients to avoid using you except in circuit
> positions
> specified in their 'AllowInvalidRelays' config option.
>
> At present if we take away your Valid flag, we also necessarily take away
> your
> Running flag.
>
> We should sort out what we want to do. I think there is still a role for
> having
> "dangerous" relays -- meaning you don't use them at the beginning or the
> end of your
> path.
>
> Maybe this means we should do away with the 'Valid' flag, and add a
> !badguard along
> with !badexit?
>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 We use router_is_active() for too many checks when directory authorities
 are
 deciding how to handle relays that don't have the Valid flag.

 Once upon a time, you could be missing a Valid flag and still get the
 Running
 flag. That would cause clients to avoid using you except in circuit
 positions
 specified in their 'AllowInvalidRelays' config option.

 At present if we take away your Valid flag, we also necessarily take away
 your
 Running flag.

 We should sort out what we want to do. I think there is still a role for
 having
 "dangerous" relays -- meaning you don't use them at the beginning or the
 end of your
 path.

 Maybe this means we should do away with the 'Valid' flag, and add a
 !badguard along
 with !badexit?

 [Automatically added by flyspray2trac: Operating System: All]

--

Comment:

 Hm.  Since we already removed all non-Running routers from the consensus,
 it looks like this bug means we did away with (most of?) the non-Valid
 routers too.  Looks like nobody cared and nothing broke.  Can we just say
 that non-Valid routers never get listed?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1291#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online