[tor-bugs] #1031 [Tor Relay]: reserved identifier violation

[Tor Bug Tracker & Wiki]

#1031: reserved identifier violation
------------------------------+---------------------------------------------
 Reporter:  elfring           |         Type:  enhancement
   Status:  new               |     Priority:  minor      
Milestone:  Tor: unspecified  |    Component:  Tor Relay  
  Version:  0.2.2.6-alpha     |   Resolution:  None       
 Keywords:                    |       Parent:             
------------------------------+---------------------------------------------
Changes (by nickm):

  * milestone:  => Tor: unspecified


Old description:

> I suggest to try the search pattern "_[A-Z]+" on the source files. You
> will find some places where names begin with an underscore and an
> uppercase letter.
>
> Examples:
> - _TOR_ADDRESS_H
>   https://svn.torproject.org/cgi-
> bin/viewvc.cgi/tor/trunk/src/common/address.h?revision=17867&view=markup
>
> - _SHORT_FILE_
>   https://svn.torproject.org/cgi-
> bin/viewvc.cgi/tor/trunk/src/common/compat.h?revision=18743&view=markup
>
> This does not fit to the expected naming conventions of the C language
> standard.
> http://en.wikipedia.org/wiki/Reserved_identifier
>
> See also section "7.1.3 Reserved identifiers".
> http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1124.pdf
>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 I suggest to try the search pattern "_[A-Z]+" on the source files. You
 will find some places where names begin with an underscore and an
 uppercase letter.

 Examples:
 - _TOR_ADDRESS_H
   https://svn.torproject.org/cgi-
 bin/viewvc.cgi/tor/trunk/src/common/address.h?revision=17867&view=markup

 - _SHORT_FILE_
   https://svn.torproject.org/cgi-
 bin/viewvc.cgi/tor/trunk/src/common/compat.h?revision=18743&view=markup

 This does not fit to the expected naming conventions of the C language
 standard.
 http://en.wikipedia.org/wiki/Reserved_identifier

 See also section "7.1.3 Reserved identifiers".
 http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1124.pdf

 [Automatically added by flyspray2trac: Operating System: All]

--

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1031#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online