[tor-bugs] #2091 [Vidalia]: Support ControlSocket as well as ControlPort
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Tue Nov 9 02:08:33 UTC 2010
#2091: Support ControlSocket as well as ControlPort
-------------------------+--------------------------------------------------
Reporter: arma | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Vidalia | Version:
Keywords: | Parent:
-------------------------+--------------------------------------------------
Comment(by chiiph):
Replying to [comment:8 edmanm]:
> 4. [MAJOR] The code common to both ControlSocket.cpp and
ControlPort.cpp needs to be refactored out into your base class. It makes
no sense to have huge chunks of identical code in both places,
particularly since they both inherit from the same abstract base class.
The main problem with this is that the only parent class in common that
QLocalSocket and QTcpSocket have is QIODevice, but it has abstract
definitions of the most important methods, so I can't make the
AbstractControlMethod class implement them using a QIODevice that later on
is instanciated with a QLocalSocket or QTcpSocket, because they all use
readLine or methods like that that are pure virtual in QIODevice. Can you
see any alternative? I had a lot of problems with this when I was planning
the whole hierarchy change to add ControlSocket.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2091#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list