[tor-bugs] #911 [Tor - Relay]: Authorities assign Running flag to hibernating relays?

[Tor Bug Tracker & Wiki]

#911: Authorities assign Running flag to hibernating relays?
--------------------------------+-------------------------------------------
 Reporter:  arma                |         Type:  defect     
   Status:  needs_review        |     Priority:  minor      
Milestone:  Tor: 0.2.2.x-final  |    Component:  Tor - Relay
  Version:  0.2.0.31            |   Resolution:  None       
 Keywords:                      |       Parent:             
--------------------------------+-------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Old description:

> Mikeperry noted that it looks like authorities are assigning the Running
> flag if a relay has been reachable within the past however many minutes,
> even if the relay published its latest descriptor with "hibernating 1"
> in it.
>
> Even if so, it isn't a big deal, since those latest descriptors will
> claim
> a bandwidth of 0, and so clients will avoid them. But still, worth fixing
> at some point.
>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 Mikeperry noted that it looks like authorities are assigning the Running
 flag if a relay has been reachable within the past however many minutes,
 even if the relay published its latest descriptor with "hibernating 1"
 in it.

 Even if so, it isn't a big deal, since those latest descriptors will claim
 a bandwidth of 0, and so clients will avoid them. But still, worth fixing
 at some point.

 [Automatically added by flyspray2trac: Operating System: All]

--

Comment:

 So the fix would be to alter the code that decides how to vote, and never
 vote "Running" on an server if you have a descriptor for it with
 is_hibernating set, and the descriptor is published more recently than
 last_reachable.

 I believe the code that matters here is in dirserv_set_router_is_running.
 I was going to tag this "easy", but the fix is too trivial not to
 implement right now.  See branch "bug911" in my public repository.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/911#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online