[tor-bugs] #2291 [Tor Relay]: GETINFO Expansion

[Tor Bug Tracker & Wiki]

#2291: GETINFO Expansion
-------------------------+--------------------------------------------------
 Reporter:  atagar       |       Owner:                    
     Type:  enhancement  |      Status:  needs_review      
 Priority:  normal       |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |     Version:                    
 Keywords:               |      Parent:                    
-------------------------+--------------------------------------------------

Comment(by atagar):

 Hi Nick. Thanks for the feedback!

 > Instead of malloc + tor_snprintf, try using tor_asprintf

 Nice - done

 > Some of the stuff you're leaving unimplemented on Windows totally exists

 As discussed on irc I don't think that it's practical for me to add
 Windows support without a test system to develop on. Also, I neither care
 about that platform nor have others expressed interest so I think that
 this is best left as a 'todo' until someone that cares about Windows
 support steps forward.

 > we check for HAVE_GETRLIMIT, not MS_WINDOWS

 Fixed

 > and we give ourselves a descriptor limit on some platforms even if none
 is defined...

 I've copied the constants from the set_max_file_descriptors. I agree that
 it would be nicer for compat.c to have a getter function, however in the
 HAVE_GETRLIMIT use case it uses both the rlim_max and rlim_cur so it's
 insufficient to have a get_max_file_descriptors function (in some cases
 we'd want an int and in others we want a struct).

 > The documentation should really say whether descriptor-limit is rlim_max
 or rlim_cur.

 Specified that it's the upper limit.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2291#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online