[tor-bugs] #2291 [Tor Relay]: GETINFO Expansion

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Tue Dec 21 21:20:44 UTC 2010


#2291: GETINFO Expansion
-------------------------+--------------------------------------------------
 Reporter:  atagar       |       Owner:                    
     Type:  enhancement  |      Status:  needs_review      
 Priority:  normal       |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |     Version:                    
 Keywords:               |      Parent:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 * Instead of malloc + tor_snprintf, try using tor_asprintf.  It works like
 malloc+sprintf, except that you never need to worry about the allocation
 size.
  * Some of the stuff you're leaving unimplemented on Windows totally
 exists, I think.  See GetUserName(), for instance.
  * Over in compat.c , when we're actually doing all the rlimit work, we
 check for HAVE_GETRLIMIT, not MS_WINDOWS, and we give ourselves a
 descriptor limit on some platforms even if none is defined.  Maybe the
 process/descriptor-limit code should have a look at the result of that, or
 refactor that code somehow so it can do both get and set?
  * The documentation should really say whether descriptor-limit is
 rlim_max or rlim_cur.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2291#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list