[tor-bugs] #2190 [Tor Client]: Possible reentrant calls to libevent from libevent logging callback

[Tor Bug Tracker & Wiki]

#2190: Possible reentrant calls to libevent from libevent logging callback
------------------------+---------------------------------------------------
 Reporter:  nickm       |       Owner:  rransom           
     Type:  defect      |      Status:  needs_review      
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:12 nickm]:
 > Looks better now, though I think there's an extra set of parenthesis in
 4a9d60 for no apparent reason.

 I'm not enough of an expert on C's order of operations to know whether one
 of those sets of parentheses can be removed safely.  I would prefer to
 keep the quick check of the log domain before the slightly slower function
 call, and I'm not sure that `!` binds tighter than `&&` or that `&` binds
 tighter than `!`.  I think it's easier to read as is.

 > Right now I'm thinking that 0.2.1 should get the "easy" fix and 0.2.2.x
 and master should get the"hard" fix.

 I agree.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2190#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online