[tor-bugs] #1859 [Tor Client]: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and client

[Tor Bug Tracker & Wiki]

#1859: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and
client
------------------------+---------------------------------------------------
 Reporter:  mwenge      |       Owner:                     
     Type:  defect      |      Status:  needs_review       
 Priority:  normal      |   Milestone:                     
Component:  Tor Client  |     Version:  Tor: 0.2.2.12-alpha
 Keywords:              |      Parent:                     
------------------------+---------------------------------------------------

Comment(by nickm):

 circuituse.c, connection_edge.c : both are in reference to exit names or
 (bizarrely) extend_info.nickname.

 control.c: used for circuit building or descriptor retrieval.

 rendclient.c: used to look up routers from extend_info.
 rendservice.c: Used to find router from introduce2 cell

 router.c: Already special-cased to detect own name; used building
 MyFamily.

 routerlist.c: Used in routerlist_add_family to add a router's family.

 add_nickname_list_to_smartlist.c: Called lots of places, need to
 investigate.
 routerset_get_all_routers:Called lots of places, need to investigate.

 So next step is to review the callers of routerset_get_all_routers() and
 add_nickname_list_to_smartlist.  The others would definitely benefit from
 removing the special-case.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1859#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online