[tor-bugs] #1859 [Tor Client]: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and client

[Tor Bug Tracker & Wiki]

#1859: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and
client
------------------------+---------------------------------------------------
 Reporter:  mwenge      |       Owner:                     
     Type:  defect      |      Status:  needs_review       
 Priority:  normal      |   Milestone:                     
Component:  Tor Client  |     Version:  Tor: 0.2.2.12-alpha
 Keywords:              |      Parent:                     
------------------------+---------------------------------------------------

Comment(by nickm):

 I think there could ''maybe'' be cases when it makes sense to allow
 router_get_by_nickname() to bypass the routerlist: if you mention your own
 router by nickname in your configuration file, for instance.

 But for .exit, it definitely doesn't.

 So we either want to remove the offending code entirely, or split
 router_get_by_nickname() into two functions, one for local use and one for
 externally visible use.

 There are 16 callers of router_get_by_nickname(); time to start reviewing
 them...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1859#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online